Skip to content

SmtpJob: Fix crash in startLoginJob

Ahmad Samir requested to merge work/ahmad/smtpjob-crash-release-br into release/20.08
  • The user tries to connect to an smtp server, the password dialog is shown starting a nested eventloop with exec()
  • the connection is lost, the smtpjob is killed (due to connect() in startSmtpJob)
  • the dialog::exec returns, and the code tries to setError(KilledJobError) on an already killed job which leads to a crash

fix the issue by using QDialog::open() to make the code async.

BUG: 421930

!4 (merged)

Merge request reports