Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P PIM Messagelib
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 6
    • Merge requests 6
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PIMPIM
  • PIM Messagelib
  • Merge requests
  • !40

[RFC]: Split AttachmentControllerBase into a core class and a widget class

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Carl Schwan requested to merge work/makevieweracoreclass into master Apr 17, 2021
  • Overview 8
  • Commits 2
  • Pipelines 4
  • Changes 7

All the QObject only stuff has been moved to AbstractAttachmentControllerBase and AttachmentControllerBase inherit from it. This allow to use the class from a QML application while sharing the logic.

KMessageBox::sorry has been replaced by signal emmited by the abstract class and the base class listen to it to show the old dialog.

This is a RFC because the end goal is to make the ComposerViewer class not depend on QWidgets anymore, so it will need some similar changes to other classes. I want to make sure this change will be accepted after being cleaned up.

@vkrause @mlaurent

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/makevieweracoreclass