Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • B Bluedevil
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 3
    • Issues 3
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Bluedevil
  • Merge requests
  • !84

kcm: Standardize device deletion UI

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Nate Graham requested to merge ngraham/bluedevil:standardize-device-deletion into master Jul 14, 2022
  • Overview 9
  • Commits 2
  • Pipelines 3
  • Changes 1

Right now the UI is rather inconsistent, using three different words to describe the action ("Remove", "Delete," and "Forget") and implementing a custom dialog plus darkened overlay.

Let's standardize on the word "Forget" and use a standard Kirigami.PromptDialog which was made for exactly this type of thing.

BUG: 456439 FIXED-IN: 5.26

Before After
Before After

@teams/vdg @nicolasfella

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: standardize-device-deletion