Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma Breeze visual style
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 5
    • Issues 5
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma
  • Plasma Breeze visual style
  • Merge requests
  • !171

Merged
Created Jan 15, 2022 by Nicolas Fella@nicolasfellaDeveloper

[kstyle] Use application attribute instead of reading config file to check...

  • Overview 1
  • Commits 1
  • Pipelines 6
  • Changes 1

[kstyle] Use application attribute instead of reading config file to check whether to draw menu icons

The current code creates a KSharedConfig for every invokation, which is wasteful

There is an application attribute that we can use to check what we want

plasma-integration sets that attribute based on the same setting we are reading here

This way the config is only read when needed

There is one behavior change: plasma-integration only checks kdeglobals, not the app's config file, so overriding the behavior for one app only is no longer possible. However that's not something we expose in any UI anyway

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: work/menuicons