Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma Breeze visual style
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 4
    • Issues 4
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 14
    • Merge requests 14
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma Breeze visual style
  • Merge requests
  • !188

kstyle: fix low contrast tabs on dark

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jan Blackquill requested to merge work/janb/dark-tabs into master Feb 23, 2022
  • Overview 5
  • Commits 1
  • Pipelines 2
  • Changes 1

This fixes the contrast of tabs on dark themes by using a darkening factor on the Window colour, adjusted for whether it's light or dark, instead of using the Shadow colour for both light and dark themes.

BUG: 438627 FIXED-IN: 5.25

Before After
before_light after_light
before_dark after_dark
Edited Feb 23, 2022 by Jan Blackquill
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/janb/dark-tabs