Skip to content

Draw arrows on toolbuttons with menus and no popup delay

Arjen Hiemstra requested to merge work/ahiemstra/toolbutton_arrow into master

While working to make the desktop style responsible for tool button drawing in Kirigami, we found out that Breeze lacks any indicator when there's a menu attached to a tool button that is instant popup. This changes tool buttons to draw a downward pointing arrow when they have a menu. This makes them match the behaviour of push buttons and also of earlier versions of Kirigami. The exception is tool buttons that show only an icon, which are currently not changed. This is because they are often used for overflow or application menus and similar roles, which already indicate they are menus and there is no real nice way of determining which role the tool button is used for.

See also https://bugs.kde.org/show_bug.cgi?id=344746

Before After
oxygen-demo5 Screenshot_20200810_185907 Screenshot_20200810_185845
dolphin Screenshot_20200810_185938 Screenshot_20200810_185955

@teams/vdg

Edited by Arjen Hiemstra

Merge request reports

Loading