Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma Breeze visual style
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 5
    • Issues 5
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma Breeze visual style
  • Merge requests
  • !224

KStyle: Fix QQC2 desktop style Slider (step ticks) in RTL

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed ivan tkachenko requested to merge work/ratijas/slider-ticks into master Jun 03, 2022
  • Overview 1
  • Commits 1
  • Pipelines 2
  • Changes 1

We didn't do any mirroring to the sliders ticks position based on layout direction, and this caused qqc2-desktop-style sliders to render ticks in the wrong direction.

The two options should be used: upsideDown flag, and the layout direction value. Each of them has the potential of reversing a slider, and when both are set the slider should actually remain left-to-right. This fits the description of XOR operator.

Quoting Jan:

This wasn't broken with QWidgets because QSlider relies on (ab)using the upsideDown option in order to achieve mirroring of the groove instead of option->direction, and consequently, this change doesn't affect Qt widgets apps at all.

Co-Authored-By: Jan Blackquill uhhadd@gmail.com
BUG: 430101


Before:

KStyle_ProgressBar_RTL

After:

Breeze_Slider_ticks_RTL

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/ratijas/slider-ticks