[kstyle] Reverse default sort order indicator arrow direction

The direction of the sort order indicator arrows has historically been controversial:

  1. Camp A asserts that the arrow should reflect the currently applicable word: "ascending" or "descending". For example Ascending order should be represented by the arrow pointing up. It's ascending, get it?

  2. Camp B asserts than the arrow should reflect the visible order of items in the view. For example when the biggest things are on top, the arrow should be pointing down; it's showing you the direction of the visible items: big to small.

  3. Camp A then correctly points out that if Camp B gets their way, the arrow no longer matches the word displayed in the UI ("ascending" or "descending).

However over the years we have accidentally solved this dilemma! We all pretty much agree that the terms "ascending" and "descending" are confusing to users, and we have replaced them with human-readable descriptions such as "A-Z" and "Largest first". As a result, the arrows are no longer consistent with the words "ascending" or "descending" because we no longer show those words in the UI anymore. So the only remaining thing for the arrow to be consistent with is the set of items displayed immediately below it. For this purpose, reversing the default order per Camp B is more appropriate because then the arrow points in the direction of the sorting: biggest on top gets a downward-pointing arrow, and smallest on top gets an upward-pointing arrow.

There is a hidden option in Breeze that does just that; this patch flips it from false to true to effect the above change.





cc @teams/vdg

Merge request reports