Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Discover Discover
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • DiscoverDiscover
  • Merge requests
  • !27

Improve and modernize UI of Addons sheet

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nate Graham requested to merge ngraham/discover:improvr-addons-sheet into master Aug 26, 2020
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 1

Various improvements:

  • Put the bottom buttons in a footer so they can't scroll out of view
  • Rename "Discard" button to "Reset" since "Discard" implies closing the sheet
  • Move Apply and Reset buttons over to the right side, as is typical
  • Disable rather than hide the Apply and Reset buttons
  • Remove the icons since they add no information and were all the same
  • Make subtext less opaque rather than italic, as is our style (we can't simply port to Kirigami.BasicListItem yet because it can't support showing a checkbox to the left of the icon)

BUG: 425827 FIXED-IN: 5.20

How it looks now:

Screenshot_20200826_125144

cc @teams/vdg

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: improvr-addons-sheet