Skip to content

Mobile mode search page minor bug fixes

Matej Starc requested to merge sporknife/discover:searchPage-titleDelegate-fixes into master

This MR contains some minor bug fixes for mobile search page.

  • Page title items not correctly aligned vertically (because of Controls.Control bottom & top padding).
  • SearchPage (mobile) not hiding SearchFiled after it goes back to widescreen mode. "Fix" for a reported BUG.

Stuff that would (probably) need onHidden signal implemented:

  • Transfer search text from both search fields one to another (since search result persist, why wouldn't the text too ?).
  • (Need opinion on this) SearchField hide/show with signals. Instead of binding search field visibility to !window.wideScreen - (as I am currently doing), should I just make it change visibility depending on onShown/onHidden signals ?

What is onHidden signal mentioned above ?

  • A signal that is emitted when mobile ui is hidden (when it goes back to widescreen mode it would emit this signal).
Edited by Matej Starc

Merge request reports