Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Discover Discover
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 4
    • Issues 4
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 21
    • Merge requests 21
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • DiscoverDiscover
  • Merge requests
  • !480

ApplicationResouceButton: place icon side-by-side to the text

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Emil Velikov requested to merge xexaxo/discover:icon-text-realign into master Feb 21, 2023
  • Overview 30
  • Commits 4
  • Pipelines 5
  • Changes 2

Currently we use a ColumnLayout to place the icon, title and subtitle. This is visually awkward since it left aligns the relatively small icon where all the text follows us a blob.

Instead use a RowLayout for the icon and text, with the default spacing, ensuring we get a decent margin between the two.

This also aligns (pun intended) with the design used for the permissions UI further down.

Signed-off-by: Emil Velikov emil.velikov@collabora.com


Edit: adding a couple of pictures for illustration.

Current UI old
Proposed change new
Edited Feb 21, 2023 by Emil Velikov
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: icon-text-realign