Skip to content

Use new kirigami addons maximize component

James Graham requested to merge work/nvrwhere/maximize_components into master

This is an early implementation that I did after @ngraham suggested discover could use the new kirigami-addons maximize component that I created from the ones in use in Tokodon and Neochat. As it stands it's a test bed for the handling of multiple images with the new component because it was pretty easy to implement, but should be helpful in reviewing the kirigami-addons components.

Changes:

  • Use kirigami-addons maximizecomponent.qml
  • Update screenshot model names to match what the new component requires

TODO:

  • Do we want any of the actions (save, rotate, scale), currently they are cleared
  • Captions - do we want to add to the model or leave blank and not have one as is currently the case. Added as I need to make it mandatory even if we don't show them. Question is now do we want to show them?

Before
image

After
image

dependent upon libraries/kirigami-addons!88 (merged) and libraries/kirigami-addons!96 (merged) patch

Edited by James Graham

Merge request reports

Loading