Skip to content

Fix up PackageKit, ApplicationPage and FlatpakOldBeta navigation

ivan tkachenko requested to merge work/ratijas/work/ratijas/work into master

PackageKit

  • Drop QML import versions, remove unused imports

    Amends eabcbe7a

    This component managed to dodge my attention twice practically in a row.

  • Set standard spacing for ColumnLayout

  • PackageKitBackend: Port topObjects to AbstractResource's property

    Amends c3d6b3c6

ApplicationPage

  • Remove superfluous check for delegate's index>=0

    How could it ever be <0? The code has been modified upside-down over the years, but the check remained there without a change from the very beginning.

    See 4d8f1914

  • Bind to modelData and application changes

    Let's make less assumptions and write more reactive code. Turned out, if, say, Flatpak backend has two sources, then switching between them would result in equivalent lists of objects being assigned to a model, so Repeater would not really recreate delegates, and of course no Component.onCompleted handler would be called again in Loader. Using Qt.binding expression as an initial property value solves that. But also let's do this whole initialization in modelDataChanged handler instead, for extra bonus points.

Flatpak

  • Import Navigation from discover.qml module

    This is only needed in backend-specific components, as they are not in the same directory as the main module.

    Amends eabcbe7a

Merge request reports