Skip to content

Respect Kirigami page margins

Nate Graham requested to merge ngraham/discover:respect-page-margins into master

In multiple places, we override Kirigami's default page margins and substitute our own. This is problematic because:

  1. It makes the content not align with the header text, which looks bad.
  2. It will break if Kirigami's default paddings are ever changed.
  3. We should be respecting the default settings. If they are problematic, we should change Kirigami, not override it here. That just makes every app look inconsistent and weird.

Accordingly, respect the default padding values for Kirigami.Page.

Before After
App_page__before App_page__after

There are no visual changes for any other pages.

Edited by Nate Graham

Merge request reports