Skip to content

Improvements to capitalization, buttons and labels

Christoph Wolk requested to merge cwo/flatpak-kcm:permission_case into master

This MR contains three changes:

  • add ellipsis to "Add New" button and request generic list-add icon
  • use sentence capitalization for permissions
  • use colons in dialog FormData.labels

Details in the commit messages below.

before after
flatpak_permission_before flatpak_permission_after
flatpak_add_before flatpak_add_after

The HIG recommend that buttons that require further user input end with an ellipsis. The "Add New" button in the permission list view opens a dialog, but does not end with an ellipsis. In addition, the requested icon is bqm-add, related to digikam's BatchQueueManager. This is just a symlink to the standard list-add right now so there are no negative user-facing consequences, but it would make more sense to use a semantically appropriate icon name, in case the bqm icons get changed later.

This change adds the ellipsis to the button, and requests the list-add icon instead of bqm-add.

The list of flatpak permission labels is displayed in the kcm as a list of checkboxes; the HIG recommend that checkbox labels be sentence case but currently title case is used.

This change converts the labels to sentence case.

The FormData.label for the path/bus entry field currently ends with an ellipsis, rather than the conventional colon.

This change replaces the ellipses with colons.

Merge request reports