Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • F Flatpak KCM
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 5
    • Issues 5
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Flatpak KCM
  • Merge requests
  • !18

Make views frameless

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nate Graham requested to merge ngraham/flatpak-kcm:make-it-frameless into master Jan 20, 2023
  • Overview 0
  • Commits 1
  • Pipelines 2
  • Changes 2

The frames around these views create a "frames within frames" effect and introduce various padding inconsistencies. We can fix them all by not having any padding and using a frameless style in the first place.

Before After
Before After

The left margins for the column titles are still kinda weird looking, but this requires API changes in AbstractKCM which lives in Frameworks, and hence can't be done until KF6 because new API is KF6-only right now. An alternative might be to conditionalize the padding based on whether framedView is true or false, and that could possibly be done as a bugfix and added to KF5, but that would need to be done in KDeclarative as well, not here. If this patch is merged, I'll investigate that.

@teams/vdg

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: make-it-frameless