Skip to content

Fix removing of icons and activity settings for new and existing setups

Alexander Lohnau requested to merge work/alex/fix_removeing_of_icons into Plasma/5.18

This fixes BUG 385814 and a few other usecases.

Problems this fixes:

  • If you remove a default entry gets added back when plasmashell is restarted
  • If you select that the default entry should be shown in only one activity the change would have no effect

This is caused because the default applications don't have the 'applications:' prefix, but if you add new favorites they have this prefix. And when you want to remove a default application and uncheck the show on all activities option the targettedResource has this prefix. Consequently it is not deleted in the database.

And if you choose to display a default entry on only one activity it would be displayed on the others too, because the default entry gets shown on all activities (due to the missing prefix the default entry is not deleted/updated).

The current solution is not the prettiest but it works on new installations and also fixes existing setups.

I tested this on another setup. There I had correct defaults(with prefix) and it was working as expected. When simulation the problem by editing the sqlite database and applying the patch it worked also fine.
Edit: The reason that I didn't have issues there is that the install was pretty fresh, because of that there were no malformed default entries.

So the problem does not appear on new installations, but if you update a previous one.

Should this also go into 5.18?

@ngraham @davidedmundson @strangiatox

Edited by Alexander Lohnau

Merge request reports