Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • KDE GTK Configurator KDE GTK Configurator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 3
    • Issues 3
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • KDE GTK ConfiguratorKDE GTK Configurator
  • Merge requests
  • !31

Don't apply window_decorations.css to non-Breeze themes.

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Emilio Cobos Álvarez requested to merge emilio/kde-gtk-config:gtk-theme-change into Plasma/5.22 Jun 14, 2021
  • Overview 13
  • Commits 1
  • Pipelines 0
  • Changes 1

Some applications might want to switch GTK themes dynamically, for a variety of reasons.

For example, Firefox Nightly recently started doing this, so that Firefox theme users have a better experience if they choose a Firefox theme different from their GTK theme:

  • https://bugzilla.mozilla.org/show_bug.cgi?id=1707872

However, this causes some issues in KDE. While we usually try to switch to the most compatible theme, we might fall back to Adwaita Dark. In such case, this CSS would still apply causing artifacts as shown here:

  • https://bugzilla.mozilla.org/show_bug.cgi?id=1716285

Listen to the theme dynamically to make sure we don't apply window_decorations.css in such case.

I plan to figure out how to work around this in Firefox / figure out why Breeze dark is not working properly, but this seems worth it anyways.

BUG: 431396

Edited Aug 14, 2021 by Mikhail Zolotukhin
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gtk-theme-change