Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma Add-ons
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 7
    • Issues 7
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 28
    • Merge requests 28
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma Add-ons
  • Merge requests
  • !132

Fix DictEngine's handling of some errors

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Edo Friedman requested to merge edofriedman/kdeplasma-addons:fix_dict_general_status_responses_hang into master Apr 11, 2022
  • Overview 7
  • Commits 2
  • Pipelines 4
  • Changes 1

Some errors sent by the dictionary server could cause DictEngine to go into an infinite loop. This adds checks for the ones relevant to the DEFINE and SHOW DB commands.

To me it seems like in cases where it used to freeze it now sometimes slow down for a bit but I wasn't sure how to debug this so I think I am going need some help.

Edited Apr 16, 2022 by Fushan Wen
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix_dict_general_status_responses_hang