Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma Add-ons
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 6
    • Issues 6
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 24
    • Merge requests 24
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma Add-ons
  • Merge requests
  • !179

wallpapers/potd: fix multimonitor support

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Fushan Wen requested to merge work/fuf/potd/525fix into Plasma/5.25 Jun 19, 2022
  • Overview 0
  • Commits 1
  • Pipelines 2
  • Changes 13

After dataengine was ported away, it requires to use a self-maintained engine to properly support multi-screen wallpapers.

3 new classes are added:

  • PotdEngine: a class to manage clients, create and delete clients on demand.
  • Client: a class to process wallpaper data
  • Backend: a class used in QML side, to relay information from the client

The major part of PotdProviderModel are moved to the 3 classes, so the model class is now a pure model.

BUG: 454333 FIXED-IN: 5.25.1

(cherry picked from commit 86ef83c6)

wallpapers/potd: increase m_updateCount before updateSource

When cache is available, PotdClient::done will be directly emitted.

(cherry picked from commit 9a1180f1)

wallpapers/potd: remove redundant if statement

The while loop already checks the condition.

(cherry picked from commit 6633fa60)

wallpapers/potd: add some debug information

(cherry picked from commit 09c8337f)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/fuf/potd/525fix