Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma Add-ons
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 6
    • Issues 6
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 23
    • Merge requests 23
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma Add-ons
  • Merge requests
  • !266

applets/weather: Improve access to the location picker

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ismael Asensio requested to merge work/iasensio/weather-station-picker into master Nov 12, 2022
  • Overview 23
  • Commits 1
  • Pipelines 12
  • Changes 5

The current settings page to configure a weather station is mostly empty space, but it still launches an external dialog to pick a new location.

We can instead, have the station picker directly in the config page, so the workflow to select a new location is much more straighforward.

Now that the picker is more prominent also polish some details:

  • Add placeholder texts when there is no search in progress
  • Port the placeholder to Kiriami.PlaceholderMessage component
  • Make the busy indicator more responsive to user typing
  • Clear the list when the search field gets empty
  • Separate Location and Provider labels: it prevents long strings that overflow and force the form layout into narrow/"mobile" mode

@teams/vdg

BEFORE AFTER
No location selected weather_before_empty weatherpciker-empty
Picking a new location weather_before_picking weatherpciker-picking
Location selected weather_before_normal weatherpciker-normal
Edited Nov 18, 2022 by Ismael Asensio
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/iasensio/weather-station-picker