Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma Add-ons
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 7
    • Issues 7
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 30
    • Merge requests 30
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma Add-ons
  • Merge requests
  • !278

applets/weather: Show forecast in two rows for envcan provider

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ismael Asensio requested to merge work/iasensio/weather-night-forecast into master Nov 20, 2022
  • Overview 13
  • Commits 2
  • Pipelines 8
  • Changes 4

The envcan provider (Environment Canada Service) produces a forecast model with 13 items (7-day forecast and 6 nights).

Show them on a two row layout, so its easier to visually parse and helps avoiding visual bugs on constrained spaces (system tray popup) due to a really long width.

Ideally, this would be better set-up by the dataengine but, since they will be deprecated soon and there are alreay too many indirection layers we can do an educated guess here.

Comparison between different providers: weather-toronto

In the system tray:

BEFORE AFTER
weather-envcan-tray-before weather-envcan-tray-after

BUG: 452792 BUG: 394809 FIXED-IN: 5.27

  • First commit (not to be squashed): Simplify forecast layout: Use a simpler model and layout with just a delegate for every forecast (usually a day), instead of previous table-row driven approach.
Edited Nov 20, 2022 by Ismael Asensio
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/iasensio/weather-night-forecast