Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma Add-ons
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 6
    • Issues 6
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 24
    • Merge requests 24
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma Add-ons
  • Merge requests
  • !302

Open KCM if user clicks on the applet but Night Color is set to Always off

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Guilherme Marçal Silva requested to merge raploz/kdeplasma-addons:config_nightcolor into master Dec 24, 2022
  • Overview 1
  • Commits 1
  • Pipelines 4
  • Changes 1

Currently, if Night Color is set to Always off in the KCM, clicking the applet says Night color was turned on but nothing happens. Instead, bring the user to the KCM so they can enable it there first. The bug report asks for enabling it when clicking, but since we don't know what settings the user wants it's better to take them to the settings page. I also changed the tooltip to make it clear what clicking the icon will do.

This MR also fixes a small bug, where if Night Color is enabled but inhibited, and then the user sets it to Always off in the KCM, the tooltip would still say it was inhibited. Now the inhibition tooltip will only appear if Night Color is actually turned on, otherwise, it will show the tooltip to open the Night Color KCM. (line 34)

@teams/vdg @teams/usability

This is my first actual code change ever. Please help me if you find something wrong. :)

BUG: 417848

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: config_nightcolor