Skip to content

converterrunner: Do not round values unnecassarily

Alexander Lohnau requested to merge work/fix_long_units into master

We pass in the precision when we format the string and the rounding causes internal issues when the value is casted to an int.

Test Plan:
Large queries like 100000000000000000000000000000000000000000$ no longer produce negative results.

CCBUG: 425790

This will still need a more proper fix in the frameworks, but the rounding/toString stuff has almost no autotests, so I am a bit more cautious there ;)

@cholland

Edited by Alexander Lohnau

Merge request reports