Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma Add-ons
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 6
    • Issues 6
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 17
    • Merge requests 17
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma
  • Plasma Add-ons
  • Merge requests
  • !59

Merged
Created Mar 08, 2021 by Nate Graham@ngrahamDeveloper

[note] Add confirmation dialog when deleting note with real content

  • Overview 5
  • Commits 1
  • Changes 3

We've gotten feedback that it's too easy to accidentally delete a note now. While there is an undo notification, this is still a fairly scary thing to have happen if your accidentally-deleted note had important content in it. Also, the notification is persistent, but only persists for 60 seconds (plasmashell manually revokes it after that). So if you accidentally delete a note and go to get coffee or fail to notice the notification, the content will be lost forever.

To improve the situation here, we now show a warning dialog when you attempt to delete a note that has user-generated content in it. If the note is empty, or if the note's content is identical to the top clipboard entry (as in he case where the user created the note via middle-click paste), then it is instead deleted immediately.

Hopefully this will be an adequate compromise between the desire to make it easy to delete accidentally-created notes and the importance of keeping user data safe.

simplescreenrecorder-2021-03-07_14.16.08

simplescreenrecorder-2021-03-07_15.46.31

cc @teams/vdg

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: add-confirmation-dialog-before-deleting-sticky-note-with-contents