Skip to content

wallpapers/potd: use sentence case for scaling & change Provider position

Christoph Wolk requested to merge cwo/kdeplasma-addons:wallpaper_case_position into master

This MR contains two changes to the Picture of the Day wallpaper type; one a minor capitalization fix, the other a reordering of UI elements. Details in the commit messages:

The HIG recommend sentence case for combobox entries. The Scaling combobox in the Picture of the Day wallpaper type currently uses title case for its entries.

This change converts the labels to sentence case.

The Picture of the Day wallpaper type currently puts the Provider as the first option. This is not unreasonable, as it is certainly an important setting, but it breaks consistency with the Image and Slideshow types, which both have Positioning as the first option, and puts a large gap between the provider combobox and the thumbnail of today's picture.

This change moves the Positioning and Background color options over the provider, increasing consistency between wallpaper types and reducing the visual distance between the provider and the thumbnail.

Screenshots

before after
wallpaper_potd_before wallpaper_potd_after

See also plasma-workspace!4656 (merged)

Merge request reports