Skip to content

🍒 produce: Flush remaining frames when we are deactivating

Arjen Hiemstra requested to merge work/cherry-pick-3ef5a531 into Plasma/6.2

When we deactivate, we may still have a bunch of frames in FFmpeg's filter or encode queues. Currently, if that happens, we simply discard those frames and tear everything down, which results in files missing several frames that were actually recorded.

To avoid that, if we know we still have frames in the queues, wait with teardown until we know all frames have been processed.

This does mean setActive(false) can take a while to complete since the queues might have a large amount of frames remaining, but fixing that properly requires a different API.

BUG: 471159

(cherry picked from commit 3ef5a531)

Co-authored-by: Arjen Hiemstra ahiemstra@heimr.nl

Merge request reports

Loading