Skip to content

KCM: Fix missing OutputPanel form after disconnecting an output while the last one is selected

ivan tkachenko requested to merge work/ratijas/out-of-bounds-on-disconnect into master

When disconnecting an output and not updating selectedOutput index, it may go out of bounds, and so formlayout won't show up for any of the outputs at all.

KCM: Set selectedOutput without bindings

This is no longer relevant, since output model is no longer expected to rearrange rows depending on relative position of outputs.

Fixes a case where currently selected output in outputs view and in combobox could desync after disconnecting one of the outputs.

Other nice stuff:

KCM: Fix type errors on destruction or early initialization

file:///kde/share/kpackage/kcms/kcm_kscreen/contents/ui/OutputPanel.qml:57:13:
Unable to assign [undefined] to QString

file:///usr/local/kde/share/kpackage/kcms/kcm_kscreen/contents/ui/OutputPanel.qml:128:13:
Unable to assign [undefined] to QString
Edited by ivan tkachenko

Merge request reports