Skip to content

Properly restore "Device" combobox when the output model resets

Jakob Petsovits requested to merge jpetso/kscreen:work/jpetso/fix-reset-multiscreen into master

ScreenSortProxyModel::setSourceModel(nullptr) will cause the ComboBox to set the currentIndex property to -1, which also kills its binding. We restore the binding and ensure that we're setting an output to a valid index within the newly reset model.

To reproduce:

  1. Ensure that two or more displays are connected
  2. Drag one of the screens to a different position relative to the other screen(s)
  3. Press "Reset" button

Expected behavior:

  • "Device" combobox displays the currently selected screen

Observed behavior:

  • "Device" combobox is now empty, a screen must be selected either via combobox or by clicking one of the display representations in the screen positioning canvas in order for the combobox to have a proper selection again.

Didn't find any corresponding bug in Bugzilla, at least for the kscreen component.

Merge request reports