Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • K KScreen
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 4
    • Issues 4
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 6
    • Merge requests 6
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • KScreen
  • Merge requests
  • !46

Fix algorithm for common sizes in Generator::cloneScreens

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Fabian Vogt requested to merge work/fvogt/bug442822 into master Oct 11, 2021
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

The algorithm iterates all outputs and collects the intersection of all supported sizes. To fill the set initially, it assigns the current sizes if the preliminary result is empty, but this condition can also be true if the previous intersection resulted in an empty set. This is the case for instance when using 3 monitors, of which the second one doesn't have any modes in common with the first (e.g. rotation) and without this fix, it would return all sizes of the third monitor instead of an empty set.

Avoid this by giving up early when there's no intersection left.

BUG: 442822

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/fvogt/bug442822