Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • K KScreen
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 4
    • Issues 4
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 6
    • Merge requests 6
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • KScreen
  • Merge requests
  • !60

Fix ControlConfig::getScale converting scale to int silently

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Méven Car requested to merge meven/kscreen:fix-conversion into master Dec 01, 2021
  • Overview 5
  • Commits 1
  • Pipelines 4
  • Changes 1

In Wayland, when having a not int value for scale saved in conf for instance 1.5, when opening kcmshell5 kscreen, the scale displayed is truncated to its int value. Because of the default value in ControlConfig::getScale -1 being an int and the get() template using this type to determine return value type of the function causing a silent conversion from qreal to int.

candidate for backporting to stable branch

cc @ngraham @davidedmundson

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-conversion