Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • K KScreen
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 4
    • Issues 4
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 6
    • Merge requests 6
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • KScreen
  • Merge requests
  • !76

KCM: better handle revert timer and buttons

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Méven Car requested to merge meven/kscreen:fix-447199 into master Dec 21, 2021
  • Overview 12
  • Commits 1
  • Pipelines 18
  • Changes 1

BUG: 447199

The issue was that the revertSettings method was called when the timer timed out, the settings were reverted, the confirmMsg overlay closed and called a second time revertSettings when the kcm backend has not been reloaded yet.

This makes sure this won't happen, as either the timer of the revert button will revert the Settings but not simply closing `confirmMsg. This makes the code simpler by removing book keeping but instead using only the events.

Edited Dec 29, 2021 by Méven Car
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-447199