Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • K KScreen
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3
    • Issues 3
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma
  • KScreen
  • Merge requests
  • !77

[KDED] Remove showOutputIdentifiers and showOsd and dbus methods

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Méven Car requested to merge meven/kscreen:remove-unused-osds into master Dec 22, 2021
  • Overview 3
  • Commits 1
  • Pipelines 6
  • Changes 13

aka org.kde.kscreen.osdService.showOutputIdentifiers and org.kde.kscreen.osdService.showOsd

Keeps org.kde.kscreen.osdService.showActionSelector

kscreen has an osdmanager, where its osd are broken except since it seems 49c5d9c5 , except for the only important used one : the "select screen action" on screen connection.

AFAICT the other two: screen identification (the kcm has its own osd) and osdText are unused (https://lxr.kde.org/search?%21v=kf5-qt5&_filestring=&_string=kscreen.osdService)

The showText usecase is covered by plasma-workspace osd and identify output is implemented in the KCM.

So remove those to limit maintenance burden.

Edited Dec 22, 2021 by Méven Car
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: remove-unused-osds