Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • K KScreen
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3
    • Issues 3
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma
  • KScreen
  • Merge requests
  • !85

Replace OverlaySheet with InlineMessage

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Xuetian Weng requested to merge work/revert-dialog-with-inline-message into master Feb 11, 2022
  • Overview 5
  • Commits 1
  • Pipelines 2
  • Changes 1

This is an alternative way I think probably makes sense. !84 (merged)

Just replace overlaysheet with inline message and seems to work flawlessly. One small feature that's missing is that revert button can't get focused easily. But since Escape to cancel still work I guess that's acceptable.

The inline message text uses string concatenation temporarily to avoid translation string change in 5.24. Can be updated in master later.

A little bit lazy so I just do the screenshot in Chinese.. image

Edited Feb 11, 2022 by Xuetian Weng
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: work/revert-dialog-with-inline-message