Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • KScreenLocker KScreenLocker
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma
  • KScreenLockerKScreenLocker
  • Merge requests
  • !59

Cleanup kcheckpass support pam prompts

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged David Edmundson requested to merge work/big_cleanup into master Jan 27, 2022
  • Overview 18
  • Commits 2
  • Pipelines 6
  • Changes 24

Cleanup kcheckpass

kcheckpass existed because historically we needed to be root to check passwords. This hasn't been true for tens of years. There are no security benefits, all authentication is based on the exit status of the greeter application.

This patch drops kcheckpass and brings everything in process, but in another thread.

This also reports back more fine grained PAM control at the same time (based on the work !29) forwarding all prompts and messages.


As using prompts involves an API change to the clients we check themes are up-to-date and fall back to breeze if needed as discussed on the mailing list. This will also allow us to clear up a lot of bad code in screenlocker during the 5.25 cycle.

Edited May 04, 2022 by David Edmundson
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: work/big_cleanup