Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • KScreenLocker KScreenLocker
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma
  • KScreenLockerKScreenLocker
  • Merge requests
  • !72

Guard double authenticate calls

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged David Edmundson requested to merge work/double_auth_guard into master May 11, 2022
  • Overview 4
  • Commits 1
  • Pipelines 2
  • Changes 1

Whilst authenticating we emit signals and expect callbacks to prompts. The pam worker is inside pam_authenticate in the nested event loop.

It is not expected for GUI clients to call authenticate twice without a cancel inbetween, but we should still guard against it as it causes a mess.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: work/double_auth_guard