Skip to content

Drop call to QApplication::desktop in x11locker

David Edmundson requested to merge work/qt6_prep into master

We previously needed to create the root window so that we would be notified when the root window changed size.

Since then API has moved to QScreen to get window sizes which has other ways of monitoring changes.

This is for Qt6 porting.

Testing done: Using "sleep 5; xev" and then locking the screen (xev must not steal the input focus or be shown on top of the locker)

  • works with QApplication::desktop() removed, but fails with the entire method removed -> we assume this call is no longer necessary
  • archaeology in kde-workspace finds no explanation on why this might be necessary still

Co-authored during Frameworks meeting.

Merge request reports