Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • K KSystemStats
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • KSystemStats
  • Merge requests
  • !30

Set proper initial values for many SensorProperties

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Arjen Hiemstra requested to merge work/ahiemstra/initialvalue into master Jan 27, 2022
  • Overview 6
  • Commits 1
  • Pipelines 4
  • Changes 11

SensorProperty in libksysguard was changed to reset the value of a sensor on unsubscribe. However, this caused a number of "static" sensors to break and only provide their value once. To fix this, SensorProperty will now only reset the value if a valid initial value was provided.

This changes many SensorProperties to have valid initial values. This has been applied primarily to sensors that are very volatile and which provide a different value almost every update, like the various rate sensors as well as the usage percentage sensors. For these sensors, it is unlikely thata a historical value makes any sense.

Other sensors, like memory usage, are less volatile and will generally not vary wildly, so providing a historical value for those seems better than an empty value.

BUG: 446414

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/ahiemstra/initialvalue