Skip to content

effects: Drop EffectsHandler::screenGeometryChanged()

Vlad Zahorodnii requested to merge work/effects-screen-geometry into master

It's confusing to have two signals (virtualScreenGeometryChanged() and screenGeometryChanged()) that indicate the same thing.

The only difference between two is that the screenGeometryChanged() signal is emitted after the Workspace processes output changes, but no effect relies on this and it's not stated in the documentation. The reason why we have two signals is purely historical.

The screenGeometryChanged() signal was introduced first, there was no concrete reason to wire it to Workspace::desktopResized() other than convenience. The virtualScreenGeometryChanged() signal was introduced later together with Screens::size() and Screens::geometry().

Merge request reports