Skip to content

Link builtin effects with kwin executables

Vlad Zahorodnii requested to merge work/zzag/exe-builtin-effects into master

The main motivation behind this change is to prepare kwin for importing kwayland-server code in libkwin.

As is, builtin effects are linked with libkwin. Some builtin effects have wayland specific code. If we move wayland stuff in libkwin, there's going to be a circular dependency between kwin4_effect_builtins and libkwin targets.

This change intends to break that dependency by linking builtin effects to kwin executable.

The main issue with that is that EffectLoader would need to discover the effects indirectly. QStaticPlugin is used for that purpose.

Besides breaking the cyclic dependency, it makes builtin effects use the same plugin infrastructure in libkwineffects that external effects use.

Metadata in src/effects/effect_builtins.cpp was converted in a list of python dictionaries, which was fed to a python script that generated main.cpp and metadata.json files.

cc #57 (closed)

Edited by Vlad Zahorodnii

Merge request reports