Skip to content

decorations: when color scheme has no Header colors, don't ask for them

Nate Graham requested to merge ngraham/kwin:small-refactor-for-decorationpalette into master

Two commits:

commit 6c2834cc8a9750ffb9e52ef7c445ddcccba07c01
Author: Nate Graham <nate@kde.org>
Date:   Tue Oct 19 07:20:02 2021 -0600

    decorations: small refactor for decorationpalette.cpp
    
    Handle header color schemes first since the code is smaller for that
    block, which makes things more readable.
commit 00ade26624b609038f20bf31d9601821b2fbfd0e
Author: Nate Graham <nate@kde.org>
Date:   Tue Oct 19 07:16:58 2021 -0600

    decorations: when color scheme has no Header colors, don't ask for them
    
    First we check to see if the color scheme has header colors, and if it
    doesn't, we turn around and ask for them anyway, relying on implicit
    behavior in kcolorscheme that falls back to Window colors when Header
    colors are requested but are not present. Instead, let's just ask for
    Window colors to avoid the run-around and stop relying on implicit
    behavior.

cc @vladz @ndavis

Merge request reports