Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • KWin KWin
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 58
    • Issues 58
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 149
    • Merge requests 149
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • KWinKWin
  • Merge requests
  • !1689

Speed up EffectQuickView teardown

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged David Edmundson requested to merge work/teardown_context_current into master Nov 19, 2021
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

On my Nvidia machine there was a massive lag exitingthe overview effect. Hotspot showed it as being in QOpenGLVertexArrayObjectPrivate::destroy. In this method we clean up some shared objects used in the context when the context closes.

In order to do this we need the context to be current. If it is not current Qt currently internally creates a temporary offscreen surface.

To fix this we need to have our context current during destruction, which includes changing order so it is destroyed before the surface.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/teardown_context_current