Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • KWin KWin
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 39
    • Issues 39
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 108
    • Merge requests 108
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma
  • KWinKWin
  • Merge requests
  • !1802

Closed
Created Dec 15, 2021 by Vlad Zahorodnii@vladzDeveloper
  • Report abuse
Report abuse

Draft: autotests: Fix QuickTilingTest

  • Overview 0
  • Commits 1
  • Pipelines 4
  • Changes 2

AbstractClient::geometryRestore() is no longer initialized when the window is mapped so XdgToplevelClient can send a configure event with 0x0 size if user tries to restore initially maximized window.

However, it broke AbstractClient::setQuickTileMode().

This change intends to fix it (and relevant test) by making maximize quick tile mode compute geometry restore.

If user has dragged the window to a screen edge in order to maximize it, geometryRestore() will be set to the geometry that the window had when user started moving it; otherwise use the current geometry.

It would be nice to unify quick tile mode with maximize mode so the code looks less like spaghetti and less error-prone, but it's out of the scope of this MR.

Edited Dec 15, 2021 by Vlad Zahorodnii
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: work/zzag/fix-quick-tiling-test