Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • KWin KWin
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 41
    • Issues 41
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 106
    • Merge requests 106
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma
  • KWinKWin
  • Merge requests
  • !1887

Closed
Created Jan 16, 2022 by Fushan Wen@fusionfutureDeveloper
  • Report abuse
Report abuse

screenedge: Don't unhide panel from old edges

  • Overview 7
  • Commits 3
  • Pipelines 2
  • Changes 3

screenedge: Don't unhide panel from old edges

The panel is unhided when the screen is rotated, which is not convenient for 2-in-1 laptop users.

x11client: Use QTimer::singleShot in m_edgeGeometryTrackingConnection

frameGeometryChanged will be emitted before and after the panel is moved to the edge, but we don't want to call reserve(...) before the panel is moved.

xdgshellclient: Add a small delay before calling updateShowOnScreenEdge from frameGeometryChanged

On Wayland, frameGeometryChanged is emitted only once after a screen is rotated and before the panel is moved to any edge, so set a small delay to get the correct geometry of a screen.

This is hacky because the required delay could vary on different devices. I don't know if it's intended not to emit frameGeometryChanged again after the panel is moved (which changes the geometry of a screen).

BUG: 448420

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: work/fusionfuture/BUG448420-dont-unhide-the-panel