Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • KWin KWin
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 58
    • Issues 58
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 149
    • Merge requests 149
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • KWinKWin
  • Merge requests
  • !1973

Improvements to Gesture System

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Eric Edlund requested to merge ericedlund/kwin:gestureimprovements into master Feb 05, 2022
  • Overview 156
  • Commits 3
  • Pipelines 127
  • Changes 17

Improvements to Gesture System

  • Implement pinch gestures
  • Stop real time gesture callbacks from canceling early
  • Gesture's can now reverse without lifting fingers
  • Push new fingerCount parameter up registerGesture chain so effects can specify finger count for gestures
  • Make Desktop Grid effect use pinch
  • Overview uses swipe up

BUG: 402859

Testing:

  • I changed a lot of the internals for global shortcut gesture handling. I haven't noticed anything break, but maybe try all the global gesture shortcuts?
  • If you start a gesture swiping in one direction, than switch to the opposite direction, the gesture should reverse after you've crossed the starting point for the gesture. You shouldn't be able to start swiping up and then switch to right; you're locked on that axis. This should work with pinch and swipe, although pinch you can't really test because pinch expanding doesn't trigger anything yet. Virtual desktop switching for example, although not animated, should still respond to the final direction of your swipe.
  • Pinch contracting and swipe up 4 fingers should show the desktop grid effect and the transition should be smooth and continue backwards if you start retracting the gesture.

Preview:

Demo

Edited Mar 12, 2022 by Eric Edlund
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gestureimprovements