Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • KWin KWin
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 44
    • Issues 44
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 115
    • Merge requests 115
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma
  • KWinKWin
  • Merge requests
  • !2328

effects/slide: Refactor current grid position handling

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Vlad Zahorodnii requested to merge work/zzag/slide-refactor-position into master May 03, 2022
  • Overview 2
  • Commits 1
  • Pipelines 3
  • Changes 2

At the moment, the slide effect maintains m_currentPosition with the current position even if it's inactive. This is slightly error-prone as it is easy to overlook a case when m_currentPosition has to be updated. In fact, the slide effect doesn't handle the case when the number of rows changes.

It's less error prone if the desktop grid position is calculated on demand.

Edited May 03, 2022 by Vlad Zahorodnii
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: work/zzag/slide-refactor-position