effects/colorpicker: Fix picking colors (!2702) · Merge requests · Plasma / KWin

ivan tkachenko requested to merge work/ratijas/rgba into master Jul 22, 2022

Due to the wrong buffer format, the function failed with GL_INVALID_OPERATION error, which was silently ignored by the effect. It resulted in the constant phantom color being returned over and over again.

Co-Authored-By: David Edmundson kde@davidedmundson.co.uk
BUG: 454974
FIXED-IN: 5.24.7, 5.25.4, 5.26

It would be nice to have a test, but I'm new to KWin codebase, and testing looks quite complicated.

Also needs manual cherry-picking onto 5.24 due to changes on adjacent lines.

Edited Jul 22, 2022 by ivan tkachenko

effects/colorpicker: Fix picking colors

Merge request reports