Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • KWin KWin
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 58
    • Issues 58
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 160
    • Merge requests 160
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • KWinKWin
  • Merge requests
  • !2806

effects/desktopgrid: Rework borderWidth property in user-facing Desktop Grid settings

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Blazer Silving requested to merge breakingspell/kwin:work/breakingspell/grid-border-width into master Aug 10, 2022
  • Overview 19
  • Commits 2
  • Pipelines 9
  • Changes 5

BUG: 453994

The user-defined Desktop Grid Border Width parameter was removed in the QML rewrite, this MR originally restored it to the kcm_kwin_effects module, and integrated the value into src/effects/desktopgrid/qml/main.qml. This mostly reused the old code and parameters, but considers new structure in src/effects/desktopgrid/desktopgrideffect.cpp following the rewrite.

However, considering my use case where I simply set the integer to 0 to disable borders entirely, and that the previous solution was rather complex in config (0 to 100 pixels vs presets or a toggle), I've reworked the request into a single toggle to disable borders within the Grid effect.

image

Edited Aug 11, 2022 by Blazer Silving
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/breakingspell/grid-border-width