Skip to content

effects/desktopgrid: Fix cursor shape, desktop drop animations and background highlight's size

ivan tkachenko requested to merge work/ratijas/grid-cursor-shape into master

effects/desktopgrid: Fix cursor shape being lost while dragging a desktop

DragHandler does not travel along with its target heap, so it only affects the cursor shape when the mouse pointer is directly over it; but when a desktop is dragged far outside, the cursor resets.

Besides, this is how we already implemented it in WindowHeapDelegate.

FIXED-IN: 5.26

effects/desktopgrid: Replace highly opmitized animators with animations which work

Unfortunately, *Animator QML types have some problems with rendering, sometimes affecting general smoothness, other times (like here, for me) just not animating entirely. On my NVIDIA graphics system the animation or a desktop returning from drag just looks like a freeze for a second, then it suddenly jumps back to {0,0}. So let's just replace with less optimal NumberAnimation which works fine.

FIXED-IN: 5.26

effects/desktopgrid: Fix background highlight having extra size

Without window title being shown, background highlight should shrink as well, otherwise it created a questionable gap at the bottom e.g. in a Desktop Grid effect.

FIXED-IN: 5.26

Part of this MR I found in my old branches, but the last one was suggested today in VDG chat.

Edited by ivan tkachenko

Merge request reports