Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • KWin KWin
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 60
    • Issues 60
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 163
    • Merge requests 163
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • KWinKWin
  • Merge requests
  • !316

inputmethod: remove the workarounds

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Bhushan Shah requested to merge work/bshah/reset-context-when-we-show-panel into master Oct 02, 2020
  • Overview 11
  • Commits 1
  • Pipelines 0
  • Changes 2

Do not set emit the enabledChanged of the text-input-v2 when it requests us to show input panel, it is already enabled when you get this request

If we get the request to show input panel, reset the inputContext, there's two reason we can get this event: 1) when keyboard focus is activated or 2) when keyboard focus is changed to text field in same surface. In both cases, information in input method context is not valid anymore and should be reset.

This also fixes the crash in maliit where it ends up working on outdated input method context because we changed the text field on same surface.

Code in 5.20 branch is slightly different but I'd like to do cherry-pick of the patch there as well.

CC: @jbbgameich can you please test this and ensure it fixes crash with maliit for you?

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/bshah/reset-context-when-we-show-panel